[PATCH] D110652: [fir] Update fir.extract_value and fir.insert_value ops

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 14:23:56 PDT 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:2229
 
 def fir_InsertValueOp : fir_OneResultOp<"insert_value", [NoSideEffect]> {
   let summary = "insert a new sub-value into a copy of an existing aggregate";
----------------
Not probably for this patch, but I think we can use TypesMatch for adt and dst.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110652/new/

https://reviews.llvm.org/D110652



More information about the llvm-commits mailing list