[PATCH] D110729: [llvm-profgen] Refactor and better diagnostics

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:440
+        WithColor::warning()
+            << "Invalid transfer to external code in LBR record at line "
+            << TraceIt.getLineNumber() << ": " << TraceIt.getCurrentLine()
----------------
hoy wrote:
> Nit: "Invalid transfer" -> "Unpaired transfer"?   The incoming jump may not be captured by the current trace.
This is actually meant to capture cases like "internal/internal  external/external" where we do see internal branches, but there's no transition. So it's different from the unpaired case below. This is implicitly guaranteed because if leaf is external, we would ignore the stack trace and throw away the entire stack+lbr. But let make add a check for Index to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110729/new/

https://reviews.llvm.org/D110729