[PATCH] D110729: [llvm-profgen] Refactor and better diagnostics

[Hongtao Yu via Phabricator via llvm-commits]

hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:440
+        WithColor::warning()
+            << "Invalid transfer to external code in LBR record at line "
+            << TraceIt.getLineNumber() << ": " << TraceIt.getCurrentLine()
----------------
Nit: "Invalid transfer" -> "Unpaired transfer"?   The incoming jump may not be captured by the current trace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110729/new/

https://reviews.llvm.org/D110729