[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 11:47:16 PDT 2021


bogner accepted this revision.
bogner added a comment.

LGTM with a nitpick



================
Comment at: llvm/include/llvm/Support/DivisionMagic.h:12
+//===----------------------------------------------------------------------===//
+
+#include "llvm/ADT/APInt.h"
----------------
Please use the usual include guards (`LLVM_SUPPORT_DIVISIONMAGIC_H` etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747



More information about the llvm-commits mailing list