[PATCH] D110747: [NFC] Restore magic and magicu to a globally visible location

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 11:46:38 PDT 2021


ctetreau added a comment.

I decided to create a new file in llvm/Support rather than take one of the suggestions in Chris's diff thread because:

- MathExtras.h - I didn't want to add a #include to APInt.h where there wasn't one already. Plus, that file is already pretty big, and most users of it don't need this.
- somewhere in lib/CodeGen - our usage in my downstream is in lib/Target, which I think demonstrates that this functionality is more broadly useful.

Given this, I think a new file in lib/Support is appropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110747/new/

https://reviews.llvm.org/D110747



More information about the llvm-commits mailing list