[PATCH] D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions

Jozef Lawrynowicz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 09:07:57 PDT 2021


jozefl added inline comments.


================
Comment at: llvm/lib/Target/MSP430/MSP430ISelDAGToDAG.cpp:98
   private:
+    const MSP430Subtarget *Subtarget;
+
----------------
asl wrote:
> Do we need these changes here?
Yes, we need access to Subtarget so that the HasMSP430X predicate in MSP430InstrInfoExtended.td can check Subtarget->hasMSP430X()  before enabling all the MSP430X instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110723/new/

https://reviews.llvm.org/D110723



More information about the llvm-commits mailing list