[PATCH] D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions

Anton Korobeynikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 08:49:50 PDT 2021


asl added inline comments.


================
Comment at: llvm/lib/Target/MSP430/MSP430ISelDAGToDAG.cpp:98
   private:
+    const MSP430Subtarget *Subtarget;
+
----------------
Do we need these changes here?


================
Comment at: llvm/lib/Target/MSP430/MSP430ISelLowering.cpp:46
                                            const MSP430Subtarget &STI)
-    : TargetLowering(TM) {
+    : TargetLowering(TM), Subtarget(&STI) {
 
----------------
Ditto


================
Comment at: llvm/lib/Target/MSP430/MSP430ISelLowering.h:74
   class MSP430TargetLowering : public TargetLowering {
+    const MSP430Subtarget *Subtarget;
+
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110723/new/

https://reviews.llvm.org/D110723



More information about the llvm-commits mailing list