[PATCH] D83366: [MC] Simplify the logic of applying fixup for fragments, NFCI

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 29 00:03:03 PDT 2021


skan marked an inline comment as done.
skan added inline comments.


================
Comment at: llvm/lib/MC/MCAssembler.cpp:836
+        if (Sec.UseCodeAlign() && AF.hasEmitNops())
+          getBackend().shouldInsertFixupForCodeAlign(*this, Layout, AF);
         continue;
----------------
nickdesaulniers wrote:
> if `shouldInsertFixupForCodeAlign` returns a bool, should we be checking the return code here?
I think not,  the return value of `shouldInsertFixupForCodeAlign` depends on the target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83366/new/

https://reviews.llvm.org/D83366



More information about the llvm-commits mailing list