[PATCH] D83366: [MC] Simplify the logic of applying fixup for fragments, NFCI

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 28 12:41:06 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/MC/MCAssembler.cpp:836
+        if (Sec.UseCodeAlign() && AF.hasEmitNops())
+          getBackend().shouldInsertFixupForCodeAlign(*this, Layout, AF);
         continue;
----------------
if `shouldInsertFixupForCodeAlign` returns a bool, should we be checking the return code here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83366/new/

https://reviews.llvm.org/D83366



More information about the llvm-commits mailing list