[PATCH] D110609: [CodeGen] Fix wrapping personality symbol on ARM

Tue Sep 28 12:56:29 PDT 2021

smeenai added a comment.

In D110609#3027778 <https://reviews.llvm.org/D110609#3027778>, @smeenai wrote:

> Thanks for the review.
>
> In following your suggestion to check the binding, I noticed that the original symbol (the target of the wrapping) is retaining its weak binding, which seems counter to the intent of D33621 <https://reviews.llvm.org/D33621>. That isn't related to this patch (all wrapped symbols will exhibit this behavior, as will the personality symbol on all other backends), and I imagine it won't affect most uses of `--wrap` because everyone will reference the wrapped symbol and not the original.

I dug into this more, and it dates all the way back to rGb45c164fc25200afcf48fd5df8912a52319be3e5 <https://reviews.llvm.org/rGb45c164fc25200afcf48fd5df8912a52319be3e5>. Filed https://bugs.llvm.org/show_bug.cgi?id=52004 for this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110609/new/

https://reviews.llvm.org/D110609