[PATCH] D110609: [CodeGen] Fix wrapping personality symbol on ARM
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 28 09:27:28 PDT 2021
smeenai marked 3 inline comments as done.
smeenai added a comment.
Thanks for the review.
In following your suggestion to check the binding, I noticed that the original symbol (the target of the wrapping) is retaining its weak binding, which seems counter to the intent of D33621 <https://reviews.llvm.org/D33621>. That isn't related to this patch (all wrapped symbols will exhibit this behavior, as will the personality symbol on all other backends), and I imagine it won't affect most uses of `--wrap` because everyone will reference the wrapped symbol and not the original.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110609/new/
https://reviews.llvm.org/D110609
More information about the llvm-commits
mailing list