[PATCH] D109963: [AArch64] Split bitmask immediate of bitwise AND operation

[JinGu Kang via Phabricator via llvm-commits]

jaykang10 added a comment.

In D109963#3026741 <https://reviews.llvm.org/D109963#3026741>, @dmgreen wrote:

> Thanks. LGTM
>
> This kind of code can be incredibly easy to get wrong. Perhaps try running a bootstrap or something like it to flush out any issues.

Thanks for review. Let me run bootstrap build and check some benchmarks.



================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:146
+  uint64_t Imm = MovMI->getOperand(1).getImm();
+  if (AArch64_AM::isLogicalImmediate(Imm, RegSize))
+    return false;
----------------
dmgreen wrote:
> This appears to be checked here and at the start of splitBitmaskImm.
Yep, let me remove this one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109963/new/

https://reviews.llvm.org/D109963