[PATCH] D109963: [AArch64] Split bitmask immediate of bitwise AND operation

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.

Thanks. LGTM

This kind of code can be incredibly easy to get wrong. Perhaps try running a bootstrap or something like it to flush out any issues.



================
Comment at: llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp:146
+  uint64_t Imm = MovMI->getOperand(1).getImm();
+  if (AArch64_AM::isLogicalImmediate(Imm, RegSize))
+    return false;
----------------
This appears to be checked here and at the start of splitBitmaskImm.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109963/new/

https://reviews.llvm.org/D109963