[PATCH] D110055: [AsmPrinter] Loop over bundles in generic code

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> I think letting generic code inspect individual instructions inside bundles violates the spirit of what bundles, which should generally be opaque to generic code. I wouldn't be surprised if this breaks some out of tree target using bundles

Well it seems OK to me, given that it simplifies all the in-tree emitInstruction implementations.

Maybe the API of emitInstruction could change to take a reference to an iterator, and update the iterator to indicate how many instructions it has emitted? That way all the in-tree implementations could emit a single MachineInstr but your hypothetical out-of-tree implementation could emit an entire bundle at once.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110055/new/

https://reviews.llvm.org/D110055