[PATCH] D110374: [ThinLTO] Update combined index for SamplePGO indirect calls to locals

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:703
 
+  std::vector<EdgeTy> &mutable_calls() { return CallGraphEdgeList; }
+
----------------
wmi wrote:
> mutable_calls() const?
Can't be const since it is returning a non-const reference.

I did fix the clang-tidy warning here and change it to mutableCalls to match the coding style.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4203
 
     auto GetValueId = [&](const ValueInfo &VI) -> Optional<unsigned> {
+      return getValueId(VI.getGUID());
----------------
wmi wrote:
> Optional is not needed anymore?
The invoked IndexBitcodeWriter::getValueId does return Optional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110374/new/

https://reviews.llvm.org/D110374