[PATCH] D110374: [ThinLTO] Update combined index for SamplePGO indirect calls to locals

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:703
 
+  std::vector<EdgeTy> &mutable_calls() { return CallGraphEdgeList; }
+
----------------
mutable_calls() const?


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:4203
 
     auto GetValueId = [&](const ValueInfo &VI) -> Optional<unsigned> {
+      return getValueId(VI.getGUID());
----------------
Optional is not needed anymore?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110374/new/

https://reviews.llvm.org/D110374