[PATCH] D110320: [XCOFF] refactor error reporting.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocations-invalid.test:26
 # INVALID-SYM-NEXT:   Section (index: 1) .text {
-# INVALID-SYM-NEXT:     warning: '[[FILE]]': Invalid symbol index
+# INVALID-SYM-NEXT:     warning: '[[FILE]]': symbol index 33 exceeds symbol number 0
 # INVALID-SYM-NEXT:   }
----------------
Higuoxing wrote:
> jhenderson wrote:
> > Higuoxing wrote:
> > > 
> > Don't do this. Error messages should not have a leading capital letter as per the style guide.
> > 
> > Do consider prefixing this check with "error:", e.g. "error: the section index ..."
> Sorry for the incorrect comments. TIL.
It's okay! It would have been a good catch if there weren't a style guide rule :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110320/new/

https://reviews.llvm.org/D110320