[PATCH] D108602: [RISCV] Initial support .insn directive for the assembler.

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:156
 
+def uimm2 : Operand<XLenVT> {
+  let ParserMatchClass = UImmAsmOperand<2>;
----------------
zixuan-wu wrote:
> zixuan-wu wrote:
> > Does it forget to add UIMM2 and UIMM3 verification at verifyInstruction in RISCVInstrInfo.cpp?
> And can also make uimm2/uimm3 be instance of ImmLeaf? Which make them reusable to be used in DAG pattern.
It's also missed in match invalid switch like Match_InvalidUImm5 does in RISCVAsmparser.cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108602/new/

https://reviews.llvm.org/D108602