[PATCH] D109953: [X86][FP16] Combine the FADD(A, FMA(B, C, 0)) to FMA(B, C, A)

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47612-47621
 static SDValue combineFaddFsub(SDNode *N, SelectionDAG &DAG,
-                               const X86Subtarget &Subtarget) {
-  if (SDValue HOp = combineToHorizontalAddSub(N, DAG, Subtarget))
-    return HOp;
+                             const X86Subtarget &Subtarget) {
+if (SDValue HOp = combineToHorizontalAddSub(N, DAG, Subtarget))
+  return HOp;
 
-  if (SDValue COp = combineFaddCFmul(N, DAG, Subtarget))
-    return COp;
+if (SDValue COp = combineFaddCFmul(N, DAG, Subtarget))
+  return COp;
----------------
This seems been changed unconsciously.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47629-47634
+                                        const X86Subtarget &Subtarget,
+                                        const SDLoc &DL) {
+assert(N->getOpcode() == ISD::TRUNCATE && "Wrong opcode");
+SDValue Src = N->getOperand(0);
+unsigned SrcOpcode = Src.getOpcode();
+const TargetLowering &TLI = DAG.getTargetLoweringInfo();
----------------
The indentation is wrong too. The same below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109953/new/

https://reviews.llvm.org/D109953