[PATCH] D109482: [RISCV] Fold store of vmv.x.s to a vse with VL=1.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 15:33:16 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6596
+        SDLoc DL(N);
+        return DAG.getMemIntrinsicNode(
+            RISCVISD::VSE_VL, DL, DAG.getVTList(MVT::Other),
----------------
frasercrmck wrote:
> I was wondering what'd happen if you replaced it with a `ISD::VP_STORE`. Just thinking that a standard node would potentially provide more optimization opportunities compared to a RISCVISD node.
If I'm reading the code right, we don't recognize VP_STORE with an all ones mask as special and I think we'll end up lowering it to the vse_mask intrinsic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109482/new/

https://reviews.llvm.org/D109482



More information about the llvm-commits mailing list