[PATCH] D110012: [asan] Fixed a bug causing a crash when redzone optimization kicked in on X86 with -asan-optimize-callbacks flag on.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:27015
+    case llvm::Intrinsic::asan_check_memaccess: {
+      // Mark this as adjustsStack.
+      DAG.getMachineFunction().getFrameInfo().setAdjustsStack(true);
----------------
This comment simply repeats what the next line says, in the exact same words.
It would be better to briefly explain why this is needed instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110012/new/

https://reviews.llvm.org/D110012