[PATCH] D110012: [asan] Fixed a bug causing a crash when redzone optimization kicked in on X86 with -asan-optimize-callbacks flag on.

Kirill Stoimenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 14:59:22 PDT 2021


kstoimenov marked an inline comment as done.
kstoimenov added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:27014
     }
+    case llvm::Intrinsic::x86_asan_check_memaccess: {
+      // We need a frame pointer because this will get lowered to a Call.
----------------
eugenis wrote:
> Does the intrinsic have to be x86-specific? AFAIK it is fine to have x86-specific handling of a generic intrinsic.
I reverted it back to a generic intrinsic. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110012/new/

https://reviews.llvm.org/D110012



More information about the llvm-commits mailing list