[PATCH] D110171: [VectorCombine] Switch to using a worklist.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 374039.
fhahn marked 3 inline comments as done.
fhahn added a comment.

Address comments.

In D110171#3013272 <https://reviews.llvm.org/D110171#3013272>, @spatel wrote:

> Do you know if the compile-time diff remained the same after the changes from the initial draft? I know it's only a small diff, but I'm actually surprised given how little VectorCombine does. Maybe there's more vector code out there than I realized. :)

I took a closer look and it seems like the majority of the diff was coming from some other subtle restructuring of the code. I updated the patch to be more in inline with the original code. It looks mostly neutral now:

NewPM-O3: +0.02%
NewPM-ReleaseThinLTO: -0.00%
NewPM-ReleaseLTO-g: -0.02%

http://llvm-compile-time-tracker.com/compare.php?from=52832cd917af00e2b9c6a9d1476ba79754dcabff&to=e66520a4637290550a945d528e3e59573485dd40&stat=instructions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110171/new/

https://reviews.llvm.org/D110171

Files:
  llvm/lib/Transforms/Vectorize/VectorCombine.cpp
  llvm/test/Transforms/PhaseOrdering/AArch64/matrix-extract-insert.ll
  llvm/test/Transforms/VectorCombine/AArch64/load-extract-insert-store-scalarization.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop-inseltpoison.ll
  llvm/test/Transforms/VectorCombine/X86/extract-binop.ll
  llvm/test/Transforms/VectorCombine/load-insert-store.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110171.374039.patch
Type: text/x-patch
Size: 13410 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/81bab00c/attachment.bin>