[PATCH] D110171: [VectorCombine] Switch to using a worklist.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Do you know if the compile-time diff remained the same after the changes from the initial draft? I know it's only a small diff, but I'm actually surprised given how little VectorCombine does. Maybe there's more vector code out there than I realized. :)



================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:1057
   bool MadeChange = false;
+  auto SimplifyInst = [this](Instruction &I) {
+    Builder.SetInsertPoint(&I);
----------------
Nit: I'd name this "FoldInst" or "CombineInst" because I equate "Simplify" with "InstSimplify" and so not creating new values.


================
Comment at: llvm/test/Transforms/VectorCombine/AArch64/load-extract-insert-store-scalarization.ll:21
   %lv = load <225 x double>, <225 x double>* %A, align 8
-  %ext.0 = extractelement <225 x double> %lv, i64 0
+  %ext.0 = extractelement <225 x double> %lv, i64 1
   %mul = fmul double 20.0, %ext.0
----------------
Why change this test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110171/new/

https://reviews.llvm.org/D110171