[PATCH] D110079: [llvm-profgen] An option to dump disasm of specified symbols

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.



In D110079#3010460 <https://reviews.llvm.org/D110079#3010460>, @wlei wrote:

> Thanks for the change!
>
> Nit: probably we can add an early check in `validateCommandLine` to make sure `ShowDisassemblyOnly` must be true if `ShowSymbols` is not empty.

Sounds good.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:42
+static cl::list<std::string> ShowSymbols(
+    "show-symbols", cl::CommaSeparated,
+    cl::desc("List of symbols to print disassembly for. Accept demangled "
----------------
wenlei wrote:
> nit: `show-symbols` -> `disassemble-functions`. this only works for function. 
Makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110079/new/

https://reviews.llvm.org/D110079