[PATCH] D110079: [llvm-profgen] An option to dump disasm of specified symbols

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

Second what Lei said, adding a check in validateCommandLine would be helpful.



================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:42
+static cl::list<std::string> ShowSymbols(
+    "show-symbols", cl::CommaSeparated,
+    cl::desc("List of symbols to print disassembly for. Accept demangled "
----------------
nit: `show-symbols` -> `disassemble-functions`. this only works for function. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110079/new/

https://reviews.llvm.org/D110079