[PATCH] D110181: [InstCombine] Move InstCombineWorklist to Utils to allow reuse (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 21 08:53:23 PDT 2021
fhahn added a comment.
In D110181#3012805 <https://reviews.llvm.org/D110181#3012805>, @fhahn wrote:
> In D110171#3012460 <https://reviews.llvm.org/D110171#3012460>, @lebedev.ri wrote:
>
>> Nice!
>> I'm not sure it is a good idea to just reuse part of another pass like that.
>> Perhaps `InstCombineWorklist` should be extracted+promoted to being more reusable?
>
> Yeah, it should probably be moved. I put up D110181 <https://reviews.llvm.org/D110181> to move it to Utils and rename it to InstructionWorklist.
The comment ended up on the wrong review, should be at D110171 <https://reviews.llvm.org/D110171>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110181/new/
https://reviews.llvm.org/D110181
More information about the llvm-commits
mailing list