[PATCH] D110181: [InstCombine] Move InstCombineWorklist to Utils to allow reuse.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 08:51:51 PDT 2021


fhahn updated this revision to Diff 373952.
fhahn added a comment.

In D110171#3012460 <https://reviews.llvm.org/D110171#3012460>, @lebedev.ri wrote:

> Nice!
> I'm not sure it is a good idea to just reuse part of another pass like that.
> Perhaps `InstCombineWorklist` should be extracted+promoted to being more reusable?

Yeah, it should probably be moved. I put up D110181 <https://reviews.llvm.org/D110181> to move it to Utils and rename it to InstructionWorklist.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110181/new/

https://reviews.llvm.org/D110181

Files:
  llvm/include/llvm/Transforms/InstCombine/InstCombine.h
  llvm/include/llvm/Transforms/InstCombine/InstCombineWorklist.h
  llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
  llvm/include/llvm/Transforms/Utils/InstructionWorklist.h
  llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
  llvm/lib/Transforms/InstCombine/InstCombineInternal.h
  llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110181.373952.patch
Type: text/x-patch
Size: 11572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/373c6c5d/attachment.bin>


More information about the llvm-commits mailing list