[PATCH] D110175: [ValueTracking,VectorCombine] Allow passing DT to computeConstantRange.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 07:11:20 PDT 2021


lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LG with nit.



================
Comment at: llvm/include/llvm/Analysis/ValueTracking.h:552
                                      const Instruction *CtxI = nullptr,
-                                     unsigned Depth = 0);
+                                     unsigned Depth = 0,
+                                     const DominatorTree *DT = nullptr);
----------------
I think `Depth` should always stay the last parameter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110175/new/

https://reviews.llvm.org/D110175



More information about the llvm-commits mailing list