[PATCH] D110141: Fixed relative address in LNT profile control-flow graph.
Pavel Kosov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 21 04:36:26 PDT 2021
kpdev42 added inline comments.
================
Comment at: lnt/server/ui/static/lnt_profile.js:141
if (addressString.startsWith('#'))
- return addressCurrent + parseInt(addressString.substring(1), 16);
+ return addressCurrent + parseInt(addressString.substring(1), 10);
else
----------------
tnfchris wrote:
> Thanks for the patch! How about checking for the `0x` to determine whether it's dec or hex. This would be more robust. and do the same for the absolute address part below.
Thank you for review, please check these changes )
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110141/new/
https://reviews.llvm.org/D110141
More information about the llvm-commits
mailing list