[PATCH] D110141: Fixed relative address in LNT profile control-flow graph.

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 04:33:48 PDT 2021


kpdev42 updated this revision to Diff 373858.
kpdev42 marked an inline comment as done.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110141/new/

https://reviews.llvm.org/D110141

Files:
  lnt/server/ui/static/lnt_profile.js


Index: lnt/server/ui/static/lnt_profile.js
===================================================================
--- lnt/server/ui/static/lnt_profile.js
+++ lnt/server/ui/static/lnt_profile.js
@@ -137,10 +137,13 @@
     convertToAddress: function (addressString, addressCurrent) {
       // If the address starts with '#' it is a relative one
       // and should be processed differently
-      if (addressString.startsWith('#'))
-          return addressCurrent + parseInt(addressString.substring(1), 10);
+      var isRelative = addressString.startsWith('#');
+      var charOffset = (isRelative ? 1 : 0);
+      var base = (addressString.substring(charOffset).startsWith('0x') ? 16 : 10);
+      if (isRelative)
+        return addressCurrent + parseInt(addressString.substring(1), base);
       else
-          return parseInt(addressString, 16);
+        return parseInt(addressString, base);
     },
 
     parseDisassembly: function(counter) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110141.373858.patch
Type: text/x-patch
Size: 950 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210921/994e2c90/attachment.bin>


More information about the llvm-commits mailing list