[PATCH] D109665: [AArch64][SVE] Add patterns to generate ADR instruction

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 21 02:37:27 PDT 2021


paulwalker-arm accepted this revision.
paulwalker-arm added a comment.
This revision is now accepted and ready to land.

Just a few missing tests but otherwise looks good.



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1222-1224
+  defm : adrShiftPat<nxv4i32, nxv4i1, ADR_LSL_ZZZ_S_1, 1>;
+  defm : adrShiftPat<nxv4i32, nxv4i1, ADR_LSL_ZZZ_S_2, 2>;
+  defm : adrShiftPat<nxv4i32, nxv4i1, ADR_LSL_ZZZ_S_3, 3>;
----------------
These patterns are missing tests.  I suspect it's not worth the trouble trying to write a `getelementptr` based test given the i32 based addresses but doing the arithmetic explicitly in IR is good enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109665/new/

https://reviews.llvm.org/D109665



More information about the llvm-commits mailing list