[PATCH] D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a subscriber: bkramer.
GMNGeoffrey added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:371
-        }
-        case PCRel32TLV: {
-          Kind = x86_64::RequestTLSDescInGOTAndTransformToDelta32;
----------------
GMNGeoffrey wrote:
> foad wrote:
> > This causes a warning when I do a release build with clang 10.0.0:
> > ```
> > ELF_x86_64.cpp:308:13: warning: enumeration value 'PCRel32TLV' not handled in switch [-Wswitch]
> > ```
> I'm also seeing this and build with `-Werror`
Looks like a bad merge with https://reviews.llvm.org/D109293 (thanks @bkramer for pointing this out). I'll send a fix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109520/new/

https://reviews.llvm.org/D109520