[PATCH] D109520: [JITLink] Adopt forEachRelocation() helper in ELF x86-64 backend (NFC)

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 10:26:22 PDT 2021


GMNGeoffrey added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:371
-        }
-        case PCRel32TLV: {
-          Kind = x86_64::RequestTLSDescInGOTAndTransformToDelta32;
----------------
foad wrote:
> This causes a warning when I do a release build with clang 10.0.0:
> ```
> ELF_x86_64.cpp:308:13: warning: enumeration value 'PCRel32TLV' not handled in switch [-Wswitch]
> ```
I'm also seeing this and build with `-Werror`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109520/new/

https://reviews.llvm.org/D109520



More information about the llvm-commits mailing list