[PATCH] D108772: [LSR] Make sure that Factor fits into Base type

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

One last comment, otherwise LGTM.



================
Comment at: llvm/test/Transforms/LoopStrengthReduce/scaling-factor-incompat-type.ll:1
-; Check that it doesn't crash
+; Check that it doesn't crash, see pr42770
 ; REQUIRES: asserts
----------------
Could you add a more descriptive comment on what this is testing and how? (I.e., the characteristics of the test and what we should be observing when the optimization does the right thing.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108772/new/

https://reviews.llvm.org/D108772