[PATCH] D108772: [LSR] Make sure that Factor fits into Base type

Fri Sep 17 06:25:42 PDT 2021

danilaml marked 2 inline comments as done.
danilaml added inline comments.

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/pr42770.ll:1
 ; Check that it doesn't crash
 ; REQUIRES: asserts
----------------
qcolombet wrote:
> qcolombet wrote:
> > Could you check that we generate something sensible here as opposed to just no-crash?
> Could you set a more descriptive file name than a pr number?
> 
> E.g., incompatible IV type and add the PR number in the comment of the test.
I've added some checks although I don't really like the idea of checking the generated IR past the labels (and it looks like most of the lit tests in this folder don't do it either), since I don't want to depend on the actual optimizations made by LSR. Just that it won't try to use out-of-range scaling factor for one of the IVs.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108772/new/

https://reviews.llvm.org/D108772