[PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 17 01:06:00 PDT 2021


labath added a comment.

I suppose the meaning is "I can set breakpoints in host binaries", though if the entire symbol file plugin is not functional without the DIA SDK, then "I can parse host debug info" would be more correct, as the breakpoints are only the first thing you'll typically run into.

That said, if all test do pass with the Native pdb plugin, then I think that makes for an even stronger case to enable it if dia is unavailable. I might consider even enabling it by default. It's been in here for quite some time now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109834/new/

https://reviews.llvm.org/D109834



More information about the llvm-commits mailing list