[PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 14:33:02 PDT 2021


amccarth added a comment.

I'm trying to understand why I've never seen the problem that this patch is trying to address.

I wasn't aware of `LLVM_ENABLE_DIA_SDK` so I've never turned it off.  But I've run `check lldb` exclusively with `LLDB_USE_NATIVE_PDB_READER=TRUE` for a long time, so I'm surprised to hear that some tests somehow still depend on DIA.  Is `check-lldb-shell` not a subset of `check-lldb`?

How exactly would I reproduce the problem here?

I don't find much meaning in the term `host-breakpoints`, but maybe that's because I don't understand the bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109834/new/

https://reviews.llvm.org/D109834



More information about the llvm-commits mailing list