[PATCH] D109775: [FuncSpec] Fix isConstant check for globals

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 16 01:30:57 PDT 2021


SjoerdMeijer added a comment.

I have precommitted the test in rGa4e437e3c959 <https://reviews.llvm.org/rGa4e437e3c959ac0cb2edb733d081edc95a4fff22>.

Specialising on the address confused me, i.e. I had not yet consciously thought about allowing/disallowing it. But now having looked a bit more into this, I don't see the problem, and I don't see why we would disallow it with this patch. So think I will abandon this patch. Any thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109775/new/

https://reviews.llvm.org/D109775



More information about the llvm-commits mailing list