[PATCH] D109775: [FuncSpec] Fix isConstant check for globals
Chuanqi Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 14 20:33:00 PDT 2021
ChuanqiXu added a comment.
This looks good to me. Although we could specialize on the address, the benefit seems little. We couldn't remove the loads. We could only eliminate one argument. Although it is possible that the user computes the address as integer, in which case specialize on address could be beneficial, it seems really rare.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109775/new/
https://reviews.llvm.org/D109775
More information about the llvm-commits
mailing list