[PATCH] D109840: Add MachO signature verification test

Wed Sep 15 20:15:07 PDT 2021

nuriamari added a comment.

In D109840#3003027 <https://reviews.llvm.org/D109840#3003027>, @oontvoo wrote:

> In D109840#3002816 <https://reviews.llvm.org/D109840#3002816>, @int3 wrote:
>
>> What @oontvoo left out was how to define variables for FileCheck :) you'll want something like -D#DATAOFF=16400 here for the substitution to work. Then you can reference it via #DATAOFF. (The # indicates that the value is an integer. It only matters if you want to do arithmetic on the values, which doesn't apply in this case, but it's nice to use # anyway for clarity.)
>
> Ah, yes - I'd forgot that part. Thanks for clarifying it!
>
> not sure why this comment is not in-lined anymore. 🤔 @nuriamari  : Do you use `arc` to update this patch?

Yes, I am using `arc` to update the patch, I did notice inline comments from previous revisions disappear, but if you change the diff viewer to show the first revision, the inline comments remain. In any case, I will add the variables to the `FileCheck` lines. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109840/new/

https://reviews.llvm.org/D109840