[PATCH] D109840: Add MachO signature verification test

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 18:01:12 PDT 2021


oontvoo added a comment.

In D109840#3002816 <https://reviews.llvm.org/D109840#3002816>, @int3 wrote:

> What @oontvoo left out was how to define variables for FileCheck :) you'll want something like -D#DATAOFF=16400 here for the substitution to work. Then you can reference it via #DATAOFF. (The # indicates that the value is an integer. It only matters if you want to do arithmetic on the values, which doesn't apply in this case, but it's nice to use # anyway for clarity.)

Ah, yes - I'd forgot that part. Thanks for clarifying it!

not sure why this comment is not in-lined anymore. 🤔 @nuriamari  : Do you use `arc` to update this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109840/new/

https://reviews.llvm.org/D109840



More information about the llvm-commits mailing list