[PATCH] D108512: [flang][OpenMP] Add semantic checks for ordered construct

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 15 01:40:23 PDT 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a comment.



> Nit: Is this required?
>
>> Can you use a defined variable in the depend(sink) clause?
>
> Thanks for the notice. This is not required. I have deleted this check. The right way is to check if the variable is the worksharing-loop iteration variable and the loop iterator can be undeclared with implicit integer. I will do it together with other checks for `depend(sink: iterator +/- constant)` later. Is this ok to you?

OK with me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108512/new/

https://reviews.llvm.org/D108512



More information about the llvm-commits mailing list