[PATCH] D108512: [flang][OpenMP] Add semantic checks for ordered construct

[Peixin Qiao via Phabricator via llvm-commits]

peixin added a comment.

@kiranchandramohan  Thanks for your review.

Thanks for this work. Please submit with @sameeranjoshi as co-author. Please wait a day to see whether there are any other comments.

> 

I have added @sameeranjoshi  as co-author in summary description and will do as you suggest.

Nit: Remove the requires and switch to test_errors.py when you submit.

> 

Done

Nit: Is this required?

> Can you use a defined variable in the depend(sink) clause?

Thanks for the notice. This is not required. I have deleted this check. The right way is to check if the variable is the worksharing-loop iteration variable and the loop iterator can be undeclared with implicit integer. I will do it together with other checks for `depend(sink: iterator +/- constant)` later. Is this ok to you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108512/new/

https://reviews.llvm.org/D108512