[PATCH] D109637: [llvm-profgen] Ignore broken LBR samples

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:430
+      WithColor::warning() << "Invalid address in LBR record at line"
+                           << TraceIt.getLineNumber() << "\n";
+      break;
----------------
wenlei wrote:
> Can we have the content of the line printed? I think that helps users know what is going on immediately. We can have both line number and content, but I think content is more important. 
> nit: "line" -> "line: " (add a white space between "line" and its content)
Sounds good. Full line printed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109637/new/

https://reviews.llvm.org/D109637