[PATCH] D109637: [llvm-profgen] Ignore broken LBR samples
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 14 10:38:26 PDT 2021
wenlei added inline comments.
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:430
+ WithColor::warning() << "Invalid address in LBR record at line"
+ << TraceIt.getLineNumber() << "\n";
+ break;
----------------
Can we have the content of the line printed? I think that helps users know what is going on immediately. We can have both line number and content, but I think content is more important.
nit: "line" -> "line: " (add a white space between "line" and its content)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109637/new/
https://reviews.llvm.org/D109637
More information about the llvm-commits
mailing list