[PATCH] D109763: [gn build] Use lib_dirs instead of putting a qualified path in libs for diaguids.lib

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 09:08:08 PDT 2021


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm

Commit message nit:

> This is arguably a bit more idiomatic, and it doesn't require folks to upload

s/upload/update/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109763/new/

https://reviews.llvm.org/D109763



More information about the llvm-commits mailing list