[PATCH] D109763: [gn build] Use lib_dirs instead of putting a qualified path in libs for diaguids.lib

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: hans.
Herald added a subscriber: hiraditya.
thakis requested review of this revision.
Herald added a project: LLVM.

Follow-up to D109708 <https://reviews.llvm.org/D109708>: Using lib_dirs means this will work with ancient gn binaries.

Change the toolchain definitions to make lib_dirs have the right effect, and
pull out lib_switch of each of the tools while here.

This means we now do pass /LIBPATH: to link.exe, but since we invoke it directly
and not through clang-cl, this doesn't actually require D109624 <https://reviews.llvm.org/D109624>. And since this
is built in to GN, we don't need a config to push the flag to dependents.

This is arguably a bit more idiomatic, and it doesn't require folks to upload
their GN binaries. No effective behavior change.


https://reviews.llvm.org/D109763

Files:
  llvm/utils/gn/build/toolchain/BUILD.gn
  llvm/utils/gn/secondary/llvm/lib/DebugInfo/PDB/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109763.372488.patch
Type: text/x-patch
Size: 3442 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210914/a0e15909/attachment.bin>