[PATCH] D107378: Make enum iteration with seq safe by default

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 05:39:25 PDT 2021


gchatelet added a comment.

A few more typos and nits.



================
Comment at: llvm/include/llvm/ADT/Sequence.h:24
+///
+/// Prints: `0 1 2`.
+///
----------------
Ultra-nit: Technically there's a trailing space. same below.


================
Comment at: llvm/include/llvm/ADT/Sequence.h:36
+/// potentially unsafe iteration at every callsite with `forge_iterable_enum`.
+/// These utilities work with both enums delcared in namespaces and inside
+/// structs/classes.
----------------
typo


================
Comment at: llvm/include/llvm/ADT/Sequence.h:125
+
+// Use to declare ENUM as safe to iterate over. This can be used for enums
+// declared in namespace scope and inside class/struct (as a friend function).
----------------
"Use this macro to ...."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107378/new/

https://reviews.llvm.org/D107378



More information about the llvm-commits mailing list