[PATCH] D109671: [AMDGPU] Add BFE pattern matches for constrained shifts.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 14 01:49:17 PDT 2021


foad added a comment.

In D109671#2997988 <https://reviews.llvm.org/D109671#2997988>, @arsenm wrote:

> In D109671#2996887 <https://reviews.llvm.org/D109671#2996887>, @foad wrote:
>
>> This will give the wrong result when $width is zero.
>
> I'm not seeing the problem with 0?

If $width is zero then the patterns being matched return $src unchanged, but the V_BFE instruction returns zero.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109671/new/

https://reviews.llvm.org/D109671



More information about the llvm-commits mailing list